Update native.py: use dict instead of Dict#698
Update native.py: use dict instead of Dict#698wyattscarpenter wants to merge 1 commit intodatabricks:maindatabricks/databricks-sql-python:mainfrom wyattscarpenter:patch-4wyattscarpenter/databricks-sql-python:patch-4Copy head branch name to clipboard
Conversation
|
This package is supposed to still support Python 3.8 though. |
|
@amarvin Thanks for mentioning! That claim conflicts with the readme. https://github.com/databricks/databricks-sql-python?tab=readme-ov-file#requirements
However, it does seem to match the information given on https://pypi.org/project/databricks-sql-connector/, which is a release from today.
I'm happy to draft this PR if we really do support 3.8 here. Easy to change the readme if so... or change the other requirement if not. Also, no unit tests run on 3.8. If 3.8 is supported, they probably should. Also, while someone is looking into it, it's arguably wrong to specify Python <4.0.0. There's a whole thread about it somewhere. You can just leave that off. |
The capital letter alias from typing has been deprecated since Python 3.9 https://docs.python.org/3/library/typing.html#typing.Dict Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
97a12bd to
f210643
Compare
The capital letter version from typing has been deprecated since Python 3.9 https://docs.python.org/3/library/typing.html#typing.Dict
What type of PR is this?
How is this tested?
Type check in the CI