SEA: Reduce network calls for synchronous commands#633
Merged
varun-edachali-dbx merged 8 commits intoJul 19, 2025
sea-migrationdatabricks/databricks-sql-python:sea-migrationfrom
sea-optimise-successdatabricks/databricks-sql-python:sea-optimise-successCopy head branch name to clipboard
Merged
SEA: Reduce network calls for synchronous commands#633varun-edachali-dbx merged 8 commits intosea-migrationdatabricks/databricks-sql-python:sea-migrationfrom sea-optimise-successdatabricks/databricks-sql-python:sea-optimise-successCopy head branch name to clipboard
varun-edachali-dbx merged 8 commits into
sea-migrationdatabricks/databricks-sql-python:sea-migrationfrom
sea-optimise-successdatabricks/databricks-sql-python:sea-optimise-successCopy head branch name to clipboard
Conversation
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Contributor
jayantsing-db
left a comment
There was a problem hiding this comment.
Some questions inline.
jayantsing-db
approved these changes
Jul 17, 2025
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
In
execute_commandwe first send the execute request to the server, following which, if the request is synchronous, we poll for the request state until it is no longer in the pending state. Following this, we make an additionalGETrequest to the server to get the final request information. There are two areas of improvement:wait_timeout, then we need not poll for completion or make anotherGETrequest to the server. We can immediately construct ourResultSetwith the provided response.ResultSet. We need not make anotherGETrequest to the server after we are done polling and can instead utilise the last response provided.How is this tested?
Related Tickets & Documents
N/A