Add test to check thrift field IDs#602
Merged
vikrantpuppala merged 4 commits intoJun 24, 2025
maindatabricks/databricks-sql-python:mainfrom
thrift-field-testdatabricks/databricks-sql-python:thrift-field-testCopy head branch name to clipboard
Merged
Add test to check thrift field IDs#602vikrantpuppala merged 4 commits intomaindatabricks/databricks-sql-python:mainfrom thrift-field-testdatabricks/databricks-sql-python:thrift-field-testCopy head branch name to clipboard
vikrantpuppala merged 4 commits into
maindatabricks/databricks-sql-python:mainfrom
thrift-field-testdatabricks/databricks-sql-python:thrift-field-testCopy head branch name to clipboard
Conversation
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
8 tasks
jprakash-db
approved these changes
Jun 17, 2025
Contributor
jprakash-db
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making the changes
samikshya-db
approved these changes
Jun 18, 2025
gopalldb
approved these changes
Jun 19, 2025
saishreeeee
pushed a commit
that referenced
this pull request
Jun 25, 2025
* Add test to check thrift field IDs --------- Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Add test to check thrift field IDs
How is this tested?
Checked that the test fails without the known exceptions added
Related Tickets & Documents