Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Relax panda and alembic requirements#116

Closed
bkyryliuk wants to merge 1 commit into
databricks:maindatabricks/databricks-sql-python:mainfrom
bkyryliuk:bogdan/relax_depsbkyryliuk/databricks-sql-python:bogdan/relax_depsCopy head branch name to clipboard
Closed

Relax panda and alembic requirements#116
bkyryliuk wants to merge 1 commit into
databricks:maindatabricks/databricks-sql-python:mainfrom
bkyryliuk:bogdan/relax_depsbkyryliuk/databricks-sql-python:bogdan/relax_depsCopy head branch name to clipboard

Conversation

@bkyryliuk
Copy link
Copy Markdown
Contributor

Pandas 1.3+ has a regression: pandas-dev/pandas#42549
This PR proposes relaxing alembic and panda requirements

@susodapop
Copy link
Copy Markdown
Contributor

Good idea.

I'm working on this exact change locally, actually. Just running our e2e tests before pushing my own branch. This PR won't quite work because you haven't included the DCO in your commit (see CONTRIBUTING.md for details).

@bkyryliuk
Copy link
Copy Markdown
Contributor Author

Good idea.

I'm working on this exact change locally, actually. Just running our e2e tests before pushing my own branch. This PR won't quite work because you haven't included the DCO in your commit (see CONTRIBUTING.md for details).

that's great. TY! Will check on DCO

@bkyryliuk bkyryliuk force-pushed the bogdan/relax_deps branch from 502855f to 4685d6f Compare May 3, 2023 16:33
Signed-off-by: Bogdan Kyryliuk <b.kyryliuk@gmail.com>
@bkyryliuk bkyryliuk force-pushed the bogdan/relax_deps branch from 4685d6f to 7c79cbe Compare May 3, 2023 16:34
@susodapop
Copy link
Copy Markdown
Contributor

I've mirrored this change in #119 so I can verify it builds. This change will be part of v2.5.2 releasing shortly.

@susodapop susodapop closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.