Statement level query tag in NodeJS connector#366
Merged
jiabin-hu merged 7 commits intoMay 3, 2026
maindatabricks/databricks-sql-nodejs:mainfrom
jiabin-hu/query-tagsdatabricks/databricks-sql-nodejs:jiabin-hu/query-tagsCopy head branch name to clipboard
Merged
Statement level query tag in NodeJS connector#366jiabin-hu merged 7 commits intomaindatabricks/databricks-sql-nodejs:mainfrom jiabin-hu/query-tagsdatabricks/databricks-sql-nodejs:jiabin-hu/query-tagsCopy head branch name to clipboard
jiabin-hu merged 7 commits into
maindatabricks/databricks-sql-nodejs:mainfrom
jiabin-hu/query-tagsdatabricks/databricks-sql-nodejs:jiabin-hu/query-tagsCopy head branch name to clipboard
Conversation
Signed-off-by: Jiabin Hu <jiabin.hu@databricks.com>
Co-authored-by: Isaac Signed-off-by: Jiabin Hu <jiabin.hu@databricks.com>
Signed-off-by: Jiabin Hu <jiabin.hu@databricks.com>
Signed-off-by: Jiabin Hu <jiabin.hu@databricks.com>
Signed-off-by: Jiabin Hu <jiabin.hu@databricks.com>
samikshya-db
approved these changes
May 2, 2026
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
- Use dot notation for QUERY_TAGS configuration access - Convert serializeQueryTags to default export Co-authored-by: Isaac Signed-off-by: Jiabin Hu <jiabin.hu@databricks.com>
d769374 to
310e561
Compare
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: Jiabin Hu <jiabin.hu@databricks.com>
95807fb to
9936f37
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queryTagsoption toExecuteStatementOptionsfor per-statement query taggingserializeQueryTags()utility that converts a key/value dict to a comma-separatedkey:valuestring (matching the Python connector's format), with backslash-escaping for special characters in valuesconfOverlay["query_tags"]onTExecuteStatementReq, consistent with the Python connectorimplementation
This PR replaces #339
Test plan
serializeQueryTagscovering null/empty input, basic serialization, null values, and special character escaping (tests/unit/utils/queryTags.test.ts)executeStatementverifyingconfOverlay.query_tagsis set/unset correctly (tests/unit/DBSQLSession.test.ts)npm testto confirm all unit tests pass