Tweak NPM (some improvements)#29
Merged
kravets-levko merged 2 commits intoJul 12, 2022
databricks:masterdatabricks/databricks-sql-nodejs:masterfrom
kravets-levko:tweak-npm-2Copy head branch name to clipboard
Merged
Tweak NPM (some improvements)#29kravets-levko merged 2 commits intodatabricks:masterdatabricks/databricks-sql-nodejs:masterfrom kravets-levko:tweak-npm-2Copy head branch name to clipboard
kravets-levko merged 2 commits into
databricks:masterdatabricks/databricks-sql-nodejs:masterfrom
kravets-levko:tweak-npm-2Copy head branch name to clipboard
Conversation
moderakh
reviewed
Jul 12, 2022
| - name: Run unit tests | ||
| run: | | ||
| npm ci | ||
| npm run build |
Contributor
There was a problem hiding this comment.
for running the tests, don't we need to build the package to ensure the files are generated?
Contributor
Author
There was a problem hiding this comment.
prepare script is executed when you:
- run
npm installornpm ciin order to prepare package itself (but it doesn't when you install package into another project vianpm install <package-name>) - before
npm packandnpm publish
So after npm ci it will be completely ready for use
Contributor
Author
There was a problem hiding this comment.
Also I checked CI - unit tests are still passing (as well as e2e are running but fail with connection error), which basically confirms that it works 🙂
Contributor
There was a problem hiding this comment.
Thanks @kravets-levko for the explanation.
one other question for you, not directly related to this PR though, as this has been failing for a while.
why is the second CI failing?
Contributor
Author
There was a problem hiding this comment.
It needs credentials which are passed through repository secrets. But Github does not pass secrets to PRs from forks (there are security reasons). Therefore it doesn't pass on such external PRs, but will pass on PRs within the repo and on master. Currently we're trying to find some solution for this
moderakh
approved these changes
Jul 12, 2022
moderakh
left a comment
Contributor
There was a problem hiding this comment.
LGTM. thanks @kravets-levko
msrathore-db
added a commit
that referenced
this pull request
May 17, 2026
Rust source changes (native/sea/src/connection.rs + statement.rs) deferred to kernel repo PR #29 (kernel-napi-statement-validity) since napi/src now lives in databricks-sql-kernel/napi/. SeaOperationBackend.ts conflict resolved using integration commit 3da7aa7 (combining sea-results fetch pipeline with sea-operation lifecycle helpers).
msrathore-db
added a commit
that referenced
this pull request
May 24, 2026
Rust source changes (native/sea/src/connection.rs + statement.rs) deferred to kernel repo PR #29 (kernel-napi-statement-validity) since napi/src now lives in databricks-sql-kernel/napi/. SeaOperationBackend.ts conflict resolved using integration commit 3da7aa7 (combining sea-results fetch pipeline with sea-operation lifecycle helpers).
msrathore-db
added a commit
that referenced
this pull request
May 24, 2026
Rust source changes (native/sea/src/connection.rs + statement.rs) deferred to kernel repo PR #29 (kernel-napi-statement-validity) since napi/src now lives in databricks-sql-kernel/napi/. SeaOperationBackend.ts conflict resolved using integration commit 3da7aa7 (combining sea-results fetch pipeline with sea-operation lifecycle helpers). Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
msrathore-db
added a commit
that referenced
this pull request
May 31, 2026
Rust source changes (native/sea/src/connection.rs + statement.rs) deferred to kernel repo PR #29 (kernel-napi-statement-validity) since napi/src now lives in databricks-sql-kernel/napi/. SeaOperationBackend.ts conflict resolved using integration commit 3da7aa7 (combining sea-results fetch pipeline with sea-operation lifecycle helpers). Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
msrathore-db
added a commit
that referenced
this pull request
May 31, 2026
Rust source changes (native/sea/src/connection.rs + statement.rs) deferred to kernel repo PR #29 (kernel-napi-statement-validity) since napi/src now lives in databricks-sql-kernel/napi/. SeaOperationBackend.ts conflict resolved using integration commit 3da7aa7 (combining sea-results fetch pipeline with sea-operation lifecycle helpers). Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly improve #28