Chore#255
Merged
kravets-levko merged 6 commits intoApr 29, 2024
maindatabricks/databricks-sql-nodejs:mainfrom
chores-2024-04-23databricks/databricks-sql-nodejs:chores-2024-04-23Copy head branch name to clipboard
Merged
Chore#255kravets-levko merged 6 commits intomaindatabricks/databricks-sql-nodejs:mainfrom chores-2024-04-23databricks/databricks-sql-nodejs:chores-2024-04-23Copy head branch name to clipboard
kravets-levko merged 6 commits into
maindatabricks/databricks-sql-nodejs:mainfrom
chores-2024-04-23databricks/databricks-sql-nodejs:chores-2024-04-23Copy head branch name to clipboard
Conversation
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
…yTimeout` options Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
benc-db
approved these changes
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each commit is a separate change:
lib/hive/Types- some types there were just re-exports, some were used in the only place, some were unused at all. The only type that was used more than once was replaced by a functionmaxRowsandqueryTimeout(related to Documentation on timeout options needs clarification #167)queryTimeoutoption (also related to Documentation on timeout options needs clarification #167)AuthenticationErrorclass instead of a genericErrorfor errors in auth-related code