Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix polyfill#254

Merged
kravets-levko merged 1 commit into
maindatabricks/databricks-sql-nodejs:mainfrom
fix-polyfilldatabricks/databricks-sql-nodejs:fix-polyfillCopy head branch name to clipboard
Apr 29, 2024
Merged

Fix polyfill#254
kravets-levko merged 1 commit into
maindatabricks/databricks-sql-nodejs:mainfrom
fix-polyfilldatabricks/databricks-sql-nodejs:fix-polyfillCopy head branch name to clipboard

Conversation

@kravets-levko
Copy link
Copy Markdown
Contributor

Change condition in polyfill. hasOwnProperty still returns true if property is available but its value is undefined. Also, the condition contained typo. Instead, explicitly check if ArrayConstructor.prototype.at is a function.

Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko merged commit 9913384 into main Apr 29, 2024
@kravets-levko kravets-levko deleted the fix-polyfill branch April 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.