Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update thrift library patch and prepare release#140

Merged
kravets-levko merged 5 commits into
maindatabricks/databricks-sql-nodejs:mainfrom
update-thrift-patchdatabricks/databricks-sql-nodejs:update-thrift-patchCopy head branch name to clipboard
Apr 20, 2023
Merged

Update thrift library patch and prepare release#140
kravets-levko merged 5 commits into
maindatabricks/databricks-sql-nodejs:mainfrom
update-thrift-patchdatabricks/databricks-sql-nodejs:update-thrift-patchCopy head branch name to clipboard

Conversation

@kravets-levko
Copy link
Copy Markdown
Contributor

@kravets-levko kravets-levko commented Apr 18, 2023

Update our patch for thrift dependency: immediately stop processing respone on HTTP error statuses (non-200), otherwise it leads to weird errors when trying to parse Thrift response body. Related to ES-662981

Update to the way we ship patched thrift dependency: Yarn 2 and upper does not respect bundledPackages field and completely ignores bundled dependencies. Instead, we copy patched thrift into dist/node_modules explicitly. It works because Nodejs looks in nested node_modules first, and only if package not found there - will attempt to go up the directory tree. Dependencies of thrift itself will still be located at their default locations since we still depend on thrift library and it will be installed as usual.

Also, with the changes mentioned above, we're going to release next library version, so all preparation steps are performed as well (update package.json, changdelog, etc.)

Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.