fix(binder): correct join statistics propagation#20122
Open
forsaken628 wants to merge 6 commits into
Open
fix(binder): correct join statistics propagation#20122forsaken628 wants to merge 6 commits into
forsaken628 wants to merge 6 commits into
Conversation
Contributor
Docker Image for PR
|
Contributor
ClickBench Report |
forsaken628
force-pushed
the
tpcds
branch
2 times, most recently
from
July 10, 2026 14:03
cb7ad1c to
adaf7bf
Compare
Contributor
Docker Image for PR
|
Contributor
ClickBench Report |
Contributor
Docker Image for PR
|
forsaken628
marked this pull request as ready for review
July 17, 2026 07:22
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9dbace494
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Docker Image for PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
update NDV, null counts, and histograms according to join semantics
preserving the selected join tree’s updated estimates
stale cardinalities
SExprtype consistency validation, including regression fixes for Decimal eager aggregation andaggregating-index local schema symbols
goldens
Benchmark
tpcds sf 100 from 473.65s to 147.23s.
Tests
Type of change
This change is