Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Soham Internship Pipeline#1435

Open
SohamDasgupta91 wants to merge 21 commits into
data-prep-kit:devdata-prep-kit/data-prep-kit:devfrom
SohamDasgupta91:SohamDasgupta91-patch-1SohamDasgupta91/data-prep-kit:SohamDasgupta91-patch-1Copy head branch name to clipboard
Open

Soham Internship Pipeline#1435
SohamDasgupta91 wants to merge 21 commits into
data-prep-kit:devdata-prep-kit/data-prep-kit:devfrom
SohamDasgupta91:SohamDasgupta91-patch-1SohamDasgupta91/data-prep-kit:SohamDasgupta91-patch-1Copy head branch name to clipboard

Conversation

@SohamDasgupta91

Copy link
Copy Markdown

Why are these changes needed?

End to end pipeline that prompts a granite model to get article titles, passes them through the Wikimedia API and runs RAG evaluation.

Related issue number (if any).

@swith005 swith005 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SohamDasgupta91 thanks for submitting, but there's a lot of information that should be removed from checking in - such as username/passwords/tokens, etc. Please have these removed.
Would be better to include a markdown cell detailing where/how to retrieve this info for replicating the example

@swith005 swith005 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, please update PR with the following changes:

  • Add requirements.txt file for libraries necessary to work
  • Add markdown for prerequisites before running (i.e. getting wikimiedia account + token, hugging face token, setting up venv and installing specific version of dpk + requirements, etc. )
  • Add markdown for introduction and sections explaining what this notebook does, and the metrics/results
  • Ensure LLMs come from public repository (i.e. hugging face)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.