@gbhall Thanks for your contribution. 👍

Your code resolves problem, but should be improved. There are a lot of sql specific code in HttpUrlSource. HttpUrlSource shouldn't contain any database logic. The better solution is new interface ContentInfoStorage with database based implementation DatabaseContentInfoStorage. Also your implementation doesn't contain any test that proof your code works well.
Please rebase master, implement you pull request in this way, write tests.

Please notify me if you don't want improve your PR. In this case I will implement it by myself.

Sorry for looooooooong delay on your PR.

Hey man, no problem :)

Sorry I don't currently have any time to improve my PR. However if you have
any questions, feel free to ask me :)

Cheers!
Gareth

On Thu, 28 Jul 2016 at 02:30 Alexey Danilov notifications@github.com
wrote:

@gbhall https://github.com/gbhall Thanks for your contribution. 👍

Your code resolves problem, but should be improved. There are a lot of sql
specific code in HttpUrlSource. HttpUrlSource shouldn't contain any
database logic. The better solution is new interface ContentInfo with
database based implementation DatabaseContentInfo. Also your
implementation doesn't contain any test that proof your code works well.
Please rebase master, implement you pull request in this way, write tests.

Please notify me if you don't want improve your PR. In this case I will
implement it by myself.

Sorry for looooooooong delay on your PR.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#67 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABFvuahe-b_5spUNUR19knhFgCpWHDXiks5qZ6O2gaJpZM4ITfhu
.

@gbhall thanks for response. I will get your solution as start point and will improve it as described above.

Fixed here. @gbhall Thanks for contribution.

No problem man, glad I could help! :)
On Fri, 5 Aug 2016 at 7:38 PM, Alexey Danilov notifications@github.com
wrote:

Closed #67 #67.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#67 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABFvuUMBpfUATVb6r8bQOzdfN8csEf64ks5qcyCogaJpZM4ITfhu
.