Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

test(analyzer): add unit test coverage for NetEvolve.Defaults.Analyzer - #475

#475
Merged
samtrion merged 1 commit into
maindailydevops/defaults:mainfrom
feat/analyzer-unit-testsdailydevops/defaults:feat/analyzer-unit-testsCopy head branch name to clipboard
Jul 22, 2026
Merged

test(analyzer): add unit test coverage for NetEvolve.Defaults.Analyzer#475
samtrion merged 1 commit into
maindailydevops/defaults:mainfrom
feat/analyzer-unit-testsdailydevops/defaults:feat/analyzer-unit-testsCopy head branch name to clipboard

Conversation

@samtrion

Copy link
Copy Markdown
Contributor

Summary

  • Add a new NetEvolve.Defaults.Analyzer.Tests.Unit TUnit project covering IsPackableProjectDiagnosticAnalyzer, OldProjectSupportDiagnosticAnalyzer, and Helper/RuleCategory, including edge cases (missing/whitespace values, boundary years, invalid input) beyond the happy path.
  • Fix a bug found by the new tests: OldProjectSupportDiagnosticAnalyzer reported OLD0001 twice when both direngineering and direngineeringsettings were configured. It now reports once.

Test plan

  • dotnet build — clean
  • dotnet test in tests/NetEvolve.Defaults.Analyzer.Tests.Unit — 55/55 passed

🤖 Generated with Claude Code

https://claude.ai/code/session_013cR8rWVwvVY2bfM4QyKvtw

Add a new NetEvolve.Defaults.Analyzer.Tests.Unit TUnit project covering
IsPackableProjectDiagnosticAnalyzer, OldProjectSupportDiagnosticAnalyzer,
and Helper/RuleCategory, including edge cases (missing/whitespace values,
boundary years, invalid input) beyond the happy path.

fix(analyzer): stop OLD0001 from being reported twice

OldProjectSupportDiagnosticAnalyzer reported the same OLD0001 descriptor
once per configured key, so a project setting both direngineering and
direngineeringsettings received two duplicate diagnostics. Report once
when either key is configured.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013cR8rWVwvVY2bfM4QyKvtw
@samtrion
samtrion requested a review from a team as a code owner July 22, 2026 17:39
@samtrion
samtrion requested review from Hnogared and removed request for a team July 22, 2026 17:39
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • state:ready for merge

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8a6aa76d-f3f2-478e-b79c-d102e691b5cf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@samtrion
samtrion merged commit 8ceabd1 into main Jul 22, 2026
12 checks passed
@samtrion
samtrion deleted the feat/analyzer-unit-tests branch July 22, 2026 17:43
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9d1bc49) to head (193a72e).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##           main      #475        +/-   ##
===========================================
+ Coverage      0   100.00%   +100.00%     
===========================================
  Files         0         1         +1     
  Lines         0        16        +16     
  Branches      0         1         +1     
===========================================
+ Hits          0        16        +16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.