Es6module#60
Conversation
|
Dear @esjewett Now that crossfilter runs Es6 modules, any chance to get this reviewed ? |
|
@christophe-g Yup, I can look at this. Is this ready to review? |
|
@esjewett - excellent thanks. Yes it is from my perspective. I am using this branch without apparent problems. As said above, test seems to need more recent nodejs than the one in travis. |
|
@christophe-g Ok, looking good, and confirmed that the tests are passing. Two questions:
|
…ommand "sh -e /etc/init.d/xvfb start" failed and exited with 127 during .)
|
That was quick !
Done, travis success.
It will break ie. Yes it should be a major version bump. I suggest we get inspiration from latest crossfilter release (https://github.com/crossfilter/crossfilter/releases/tag/1.5.0) for release note. |
|
Excellent - thank you. I will try to get this merged and released today or this weekend. |
Port to ES6 module, same exercice as crossfilter/crossfilter#142
Tests are passing against the build file (reductio.min.js). Struggling to make them pass against src files due to karma/jasmine having trouble properly interpreting import statement.
Travis build failing, potentially due to old node engine (0.10). Running fine locally on my machine (node 10.16.3).