Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

First name with hyphen is merged into last name after save #3480

Copy link
Copy link

Description

@philipboomy
Issue body actions

What happened?

Description

When submitting separate first name and last name on the checkout then when the first name contains a hyphen "-" then after save the first name is blank the last name field contains the first name and last name.

Steps to reproduce

  1. submit first name and last name separately
  2. Make sure first name contains a hyphen "-" .e.g. "Chi-la".
  3. Last name can be anything e.g. "Smith"
  4. Submit the form.
  5. Refresh and now the first name field is empty and the last name contains "Chi-la Smith"

Expected behavior

I would expect first name field contains "Chi-la" and last name contains "Smith.

WARNING! Stripe does not not support hyphen "-" in the name so perhaps better to output this:

First name: "Chi la"
Last name: "Smith

Alternatively strip the hyphen "-" from the stripe payment request generation.

I noticed this issue as a customer couldn't pay due to Stripe having a JS error.
Uncaught (in promise) TypeError: paymentResponse.redirectData is undefined
due to no first name stored on the order.

Actual behavior

First name: (blank)
Last name: "Chi-la Smith"

Craft CMS version

4.8.10

Craft Commerce version

4.5.4

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

Craft Commercecommerce4Issues related to Commerce v4Issues related to Commerce v4severity:minorCosmetic issues or bugs with simple workaroundsCosmetic issues or bugs with simple workarounds

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

Morty Proxy This is a proxified and sanitized view of the page, visit original site.