Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

Documentation/stop: describe --uuid-file option - #3511

#3511
Merged
jonboulle merged 1 commit into
rkt:masterrkt/rkt:masterfrom
0xAX:update-docsCopy head branch name to clipboard
Jan 6, 2017
Merged

Documentation/stop: describe --uuid-file option#3511
jonboulle merged 1 commit into
rkt:masterrkt/rkt:masterfrom
0xAX:update-docsCopy head branch name to clipboard

Conversation

@0xAX

@0xAX 0xAX commented Jan 5, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@ghost

ghost commented Jan 5, 2017

Copy link
Copy Markdown

Can one of the admins verify this patch?

Comment thread Documentation/subcommands/stop.md Outdated
"93e516b0-e84b-40cf-a45b-531b14dfcce2"
```

Instead of passing UUID on command line, stop command can read the UUID from a text file.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is copied from rm, but for consistency with --force above it would be nice to have a similar line ("The --uuid-file` flag ...").

nit: stop command -> the stop command, though this phrasing might change further while including the above.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@euank yes, will add and update

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the PR

@lucab

lucab commented Jan 6, 2017

Copy link
Copy Markdown
Member

@jonboulle @euank fell free to do a last round here.

@lucab lucab added this to the v1.23.0 milestone Jan 6, 2017
@jonboulle
jonboulle merged commit 20b4815 into rkt:master Jan 6, 2017
@0xAX
0xAX deleted the update-docs branch January 8, 2017 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.