Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 18, 2019. It is now read-only.

Prevent path/param drop when both fields have the same name.#138

Open
ghost wants to merge 1 commit into
mastercore-api/python-client:masterfrom
unknown repositoryCopy head branch name to clipboard
Open

Prevent path/param drop when both fields have the same name.#138
ghost wants to merge 1 commit into
mastercore-api/python-client:masterfrom
unknown repositoryCopy head branch name to clipboard

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 7, 2017

Attempt to fix #137. While this might not be the best way, it demonstrates extracting path parameters first.

@thinkwelltwd
Copy link
Copy Markdown

thinkwelltwd commented Jun 7, 2017

@hurturk, that's working for me!

@tomchristie, would there be some way to specify a path param separately from the field params, so that the lookup_field value could be updated just as an HTML form?

@ghost
Copy link
Copy Markdown
Author

ghost commented Jun 8, 2017

Doc generated cli command already show two consequent parameters with same name fyi. Alternative solution would be to take first one as a path and the later as data.

Or if lookup_field can be used in a way just like the example in the coreapi-cli readme:

coreapi show notes 0 description

Here, instead of 0, I think lookup_field could be used? I can certainly make another PR for that when decided.

@ghost ghost changed the title Prevent path/param drop when both fields has the same name. Prevent path/param drop when both fields have the same name. Jun 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URL not constructed in PUT/PATCH methods

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.