This repository was archived by the owner on Mar 18, 2019. It is now read-only.
Fix the encoding/decoding of Enum types.#126
Closed
tbeadle wants to merge 1 commit into
Closed
Fix the encoding/decoding of Enum types.#126tbeadle wants to merge 1 commit into
tbeadle wants to merge 1 commit into
Conversation
The 'enum' argument is a required parameter to creating an Enum. Store it in an 'extra' dict that can be passed as **kwargs during its creation.
lovelydinosaur
suggested changes
Apr 7, 2017
| 'description': schema.description | ||
| } | ||
| if isinstance(schema, coreschema.Enum): | ||
| retval['extra'] = {'enum': schema.enum} |
Contributor
There was a problem hiding this comment.
I think we could just put this value directly under enum rather than having an extra dictionary.
Thanks for progressing this!
Contributor
Author
There was a problem hiding this comment.
I figured that using 'extra' would allow it to be used for other types in the future.
|
Any news on this PR? @tomchristie, do you agree with @tbeadle's comment on the usage of the extra dictionary? |
Contributor
|
Closed via #135 (pycon sprints) Thanks so much for kicking this off! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'enum' argument is a required parameter to creating an Enum. Store
it in an 'extra' dict that can be passed as **kwargs during its creation.