fix(US): Mardi Gras is a Louisiana state holiday, not New Orleans only#642
Open
g1mn wants to merge 1 commit into
commenthol:mastercommenthol/date-holidays:masterfrom
g1mn:fix/us-la-mardi-gras-statewideg1mn/date-holidays:fix/us-la-mardi-gras-statewideCopy head branch name to clipboard
Open
fix(US): Mardi Gras is a Louisiana state holiday, not New Orleans only#642g1mn wants to merge 1 commit intocommenthol:mastercommenthol/date-holidays:masterfrom g1mn:fix/us-la-mardi-gras-statewideg1mn/date-holidays:fix/us-la-mardi-gras-statewideCopy head branch name to clipboard
g1mn wants to merge 1 commit into
commenthol:mastercommenthol/date-holidays:masterfrom
g1mn:fix/us-la-mardi-gras-statewideg1mn/date-holidays:fix/us-la-mardi-gras-statewideCopy head branch name to clipboard
Conversation
US.yaml carried Mardi Gras (easter -47) under LA.regions.NO, so US-LA missed it
entirely. Louisiana state employees do not work Mardi Gras Day (R.S. 1:55
B(1)(a)), and it is a legal holiday in the 29 parishes listed in R.S. 1:55 A(3)
once the parish declares it by ordinance, plus in all municipalities - state
level is the closest fit for this library's granularity.
The NO region keeps its name so getRegions('US', 'LA') still returns it and
US-LA-NO queries keep resolving; Mardi Gras now reaches them by inheritance.
Lundi Gras is left out: the issue guessed at it, but R.S. 1:55 does not mention
the Monday before.
Fixtures regenerated with `mocha test/all.mocha.js --writetests --countries US`.
Closes commenthol#638
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #638
What
US.yamlhad Mardi Gras (easter -47) underLA.regions.NO, soUS-LAdid not return it at all — onlyUS-LA-NOdid. Mardi Gras is not a New Orleans-only holiday:Source: https://legis.la.gov/Legis/Law.aspx?d=74097
State level is the closest fit for this library's granularity, so
easter -47moves toLA.dayswith the statute cited in a comment.Two deliberate scope decisions
regions.NOis kept (name only). Dropping it would removeNOfromgetRegions('US', 'LA')and break existingUS-LA-NOlookups. Keeping the region means Mardi Gras reaches New Orleans by inheritance, so nothing regresses and theUS-LA-NO-*fixtures stay byte-identical.Verification
npm run yaml— cleannpm test— 5373 passingnpm run lint— cleanmocha test/all.mocha.js --writetests --countries US→ onlytest/fixtures/US-LA-2015..2029.jsonchange, one Mardi Gras entry each (US-LA-NO-*unchanged, as expected)US-LA→2026-02-17 Mardi Gras,US-LA-NO→ same,US-TXunaffected,getRegions('US','LA')→{"NO":"New Orleans"}Independently cross-reviewed by two AI models before submission.