Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: update references to manifest to user proper terminology - #45

#45
Merged
amoeba merged 1 commit into
columnar-tech:maincolumnar-tech/dbc:mainfrom
amoeba:fix/rename-manifest-that-really-is-driver-listCopy head branch name to clipboard
Sep 17, 2025
Merged

fix: update references to manifest to user proper terminology#45
amoeba merged 1 commit into
columnar-tech:maincolumnar-tech/dbc:mainfrom
amoeba:fix/rename-manifest-that-really-is-driver-listCopy head branch name to clipboard

Conversation

@amoeba

@amoeba amoeba commented Sep 17, 2025

Copy link
Copy Markdown
Member

Updates code where we refer to "driver list" as a manifest.

Follow-on to #21

@amoeba

amoeba commented Sep 17, 2025

Copy link
Copy Markdown
Member Author

Rebased, will merge when CI is green.

@amoeba

amoeba commented Sep 17, 2025

Copy link
Copy Markdown
Member Author

Hm, this looks like it uncovered a test flake. The test doesn't fail locally.

The difference is

  • expected:
    • installing\r\n[✓] verifying signature
  • actual:
    • installing\r\n[/] verifying signature...\r\n\r\x1b[4A\n\n\n[✓] verifying signature\r\n\nI

so it looks like it's capturing the progress spinner. I'm going to merge this but thought I'd make a note.

@amoeba
amoeba merged commit 260c2b7 into columnar-tech:main Sep 17, 2025
6 of 7 checks passed
zeroshade pushed a commit that referenced this pull request Apr 17, 2026
Updates code where we refer to "driver list" as a manifest.

Follow-on to #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.