Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat(install): add progress bar - #125

#125
Merged
zeroshade merged 2 commits into
maincolumnar-tech/dbc:mainfrom
progress-bar-installcolumnar-tech/dbc:progress-bar-installCopy head branch name to clipboard
Oct 13, 2025
Merged

feat(install): add progress bar#125
zeroshade merged 2 commits into
maincolumnar-tech/dbc:mainfrom
progress-bar-installcolumnar-tech/dbc:progress-bar-installCopy head branch name to clipboard

Conversation

@zeroshade

Copy link
Copy Markdown
Member

closes #99

@amoeba amoeba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work as expected, thanks.

What do you think about adding the file size? Especially on slower connections, users are very aware of their maximum theoretical download speed so knowing the total file size would help them know what they're getting into.

So something like,

[⠼] downloading... ██████████████░░░░░░░░░░░░░░░░░░░░░  212 KiB / 1.4 MiB

@zeroshade

Copy link
Copy Markdown
Member Author

@amoeba give it a try now 😄

@amoeba amoeba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks great, thanks

@zeroshade
zeroshade merged commit 04ccf8b into main Oct 13, 2025
13 of 14 checks passed
@zeroshade
zeroshade deleted the progress-bar-install branch October 13, 2025 17:50
zeroshade added a commit that referenced this pull request Apr 17, 2026
zeroshade added a commit that referenced this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add progress bar to install subcommand

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.