fix(site): reflect submitting state during batch update - #27630
#27630Merged
jakehwll merged 2 commits intoJul 29, 2026
maincoder/coder:mainfrom
jakehwll/fix-batch-update-submitting-statecoder/coder:jakehwll/fix-batch-update-submitting-stateCopy head branch name to clipboard
Merged
fix(site): reflect submitting state during batch update#27630jakehwll merged 2 commits intomaincoder/coder:mainfrom jakehwll/fix-batch-update-submitting-statecoder/coder:jakehwll/fix-batch-update-submitting-stateCopy head branch name to clipboard
jakehwll merged 2 commits into
maincoder/coder:mainfrom
jakehwll/fix-batch-update-submitting-statecoder/coder:jakehwll/fix-batch-update-submitting-stateCopy head branch name to clipboard
Conversation
Include updateAllMutation.isPending in the batchActions isProcessing flag so the bulk update button and modal spinner show progress while workspaces are being updated.
jakehwll
marked this pull request as ready for review
July 29, 2026 02:45
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e8fb7483a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add a page-level Storybook play story that holds the update mutation pending and asserts the Update button is disabled and announces its processing state, then clears once the mutation resolves. Guards the isProcessing wiring against regression (FE1).
jeremyruppel
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When bulk updating workspaces, the confirmation modal's Update button never entered a submitting/loading state, so there was no feedback that the update was actually in progress.
Root cause
The
BatchUpdateModalFormshows a spinner when itsisProcessingprop istrue. That prop is fed bybatchActions.isProcessingfromuseBatchActions. However, theisProcessingvalue was OR-ing together every mutation'sisPendingflag exceptupdateAllMutation— the one that actually performs the batch update:As a result, the button stayed idle for the entire duration of a bulk update.
Fix
Include
updateAllMutation.isPendingin theisProcessingderivation so the button spinner and disabled state correctly reflect an in-flight batch update.Testing