fix(site/src/pages/WorkspaceSettingsPage): correct workspace rename warning - #27622
#27622Draft
david-fraley wants to merge 1 commit into
maincoder/coder:mainfrom
dfraley/devex-674-workspace-rename-warning-copycoder/coder:dfraley/devex-674-workspace-rename-warning-copyCopy head branch name to clipboard
Draft
fix(site/src/pages/WorkspaceSettingsPage): correct workspace rename warning#27622david-fraley wants to merge 1 commit intomaincoder/coder:mainfrom dfraley/devex-674-workspace-rename-warning-copycoder/coder:dfraley/devex-674-workspace-rename-warning-copyCopy head branch name to clipboard
david-fraley wants to merge 1 commit into
maincoder/coder:mainfrom
dfraley/devex-674-workspace-rename-warning-copycoder/coder:dfraley/devex-674-workspace-rename-warning-copyCopy head branch name to clipboard
Conversation
…arning The disabled-state helper text on the workspace settings page blamed the template for renames being unavailable. Renames are gated only by the deployment-wide --allow-workspace-renames flag, so the message pointed users at a control that does not exist. Name the deployment instead, and say who can change it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves DEVEX-674.
The workspace settings page tells users that renames are "disabled by the template", but no template-level rename setting exists.
Workspace.allow_renamesis populated solely from the deployment-wide--allow-workspace-renames/CODER_ALLOW_WORKSPACE_RENAMESflag, andpatchWorkspaceenforces that flag alone. The message therefore points users at a control that does not exist.This restores the wording #11189 originally shipped with the flag, and names who can change it. The copy drifted in #13887 (2024-07-22), an unrelated org-groups PR, and has been wrong since.
Copy only. No behavior change.
Note: #27558 adds a real per-template setting, which would make template-facing wording correct. It does not touch this file, so the string needs updating there too; this PR is the backportable correction for
mainas it stands today.Proof
pages/WorkspaceSettingsPage/WorkspaceSettingsPageView→RenamesDisabledstory.Before:
After:
🤖 Generated by Coder Agents on behalf of @david-fraley.