fix(coderd): clarify error when chat model config is disabled - #27608
#27608Draft
stirby wants to merge 1 commit into
maincoder/coder:mainfrom
fix/disabled-model-config-error-messagecoder/coder:fix/disabled-model-config-error-messageCopy head branch name to clipboard
Draft
fix(coderd): clarify error when chat model config is disabled#27608stirby wants to merge 1 commit intomaincoder/coder:mainfrom fix/disabled-model-config-error-messagecoder/coder:fix/disabled-model-config-error-messageCopy head branch name to clipboard
stirby wants to merge 1 commit into
maincoder/coder:mainfrom
fix/disabled-model-config-error-messagecoder/coder:fix/disabled-model-config-error-messageCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27290
The
model_config_idvalidation incoderd/exp_chats.goreturned a single ambiguous message, "Invalid model_config_id: model config not found or disabled.", for both the not-found and disabled-model cases.Split the shared
chatModelConfigUnavailableModelNotFoundOrDisabledreason intochatModelConfigUnavailableModelNotFoundandchatModelConfigUnavailableModelDisabledso each maps to a distinct, actionable message:The provider-disabled and credentials-missing reasons already had their own distinct messages and are unchanged.
Tests: updated the existing disabled-model assertion and added a not-found case under
TestPostChats.This PR was generated by Coder Agents on behalf of @stirby.