fix(site): avoid block elements nested inside paragraph tags - #27607
#27607Draft
stirby wants to merge 1 commit into
maincoder/coder:mainfrom
fix/invalid-block-children-paragraphcoder/coder:fix/invalid-block-children-paragraphCopy head branch name to clipboard
Draft
fix(site): avoid block elements nested inside paragraph tags#27607stirby wants to merge 1 commit intomaincoder/coder:mainfrom fix/invalid-block-children-paragraphcoder/coder:fix/invalid-block-children-paragraphCopy head branch name to clipboard
stirby wants to merge 1 commit into
maincoder/coder:mainfrom
fix/invalid-block-children-paragraphcoder/coder:fix/invalid-block-children-paragraphCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26933
Two components rendered block-level elements inside
<p>tags, which browsers implicitly close before the block element. This produced a DOM that did not match the JSX, affecting layout, the accessibility tree, and hydration.GitDeviceAuth: the paragraph wrapping the one-time code andCopyButtonis now a<div>(same classes/text).OrganizationMembersPage: the remove-member confirmation dialog previously wrapped a<ul>inside a<p>; the wrapper is now a<div>.Structural-only changes; visible text, styling, and spacing are unchanged.
Checks:
biome check,tsc -p ., and LSP diagnostics all pass. No new tests added per FE1; no Storybook story renders the affected dialog/component.This PR was generated by Coder Agents on behalf of @stirby.