Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(scripts/releaser): remove doubled "v" in release calendar latest release link - #27259

#27259
Merged
mtojek merged 2 commits into
release/2.35coder/coder:release/2.35from
fix/release-calendar-doubled-version-prefixcoder/coder:fix/release-calendar-doubled-version-prefixCopy head branch name to clipboard
Jul 15, 2026
Merged

fix(scripts/releaser): remove doubled "v" in release calendar latest release link#27259
mtojek merged 2 commits into
release/2.35coder/coder:release/2.35from
fix/release-calendar-doubled-version-prefixcoder/coder:fix/release-calendar-doubled-version-prefixCopy head branch name to clipboard

Conversation

@mtojek

@mtojek mtojek commented Jul 15, 2026

Copy link
Copy Markdown
Member

Problem

The interactive releaser (scripts/releaser) renders the "Latest Release"
cell of the release calendar with a doubled version prefix, e.g.
[vv2.35.0](.../tag/v2.35.0).

version.String() already returns a v-prefixed string (e.g. v2.35.0),
but updateCalendar wrapped it in a "[v%s]" template, so the link label
gained a second v. The tag URL was already correct because release tags
carry the v prefix.

Fix

Drop the extra v from the label template ("[v%s]""[%s]"). The URL is
unchanged.

  • Label before: [vv2.35.0]
  • Label after: [v2.35.0]

Test

Added TestUpdateCalendarLatestReleaseVersionPrefix, which asserts the
LatestRelease cell for a matching row on both a patch and a minor release.
It fails on the old code ([vv2.35.x]) and passes with the fix.

Investigation notes
  • Entry path: scripts/release.shgo run ./scripts/releaser
    runReleasepromptAndUpdateDocsupdateReleaseDocs
    updateCalendarFileupdateCalendar (scripts/releaser/docs.go).
  • Root cause in updateCalendar: fmt.Sprintf("[v%s](%s)", newVer.String(), ...)
    combined with version.String() returning v%d.%d.%d.
  • Only the link label was affected; the releaseTagURLFmt URL was correct
    because tags are v-prefixed.
  • The standalone scripts/update-release-calendar.sh is a separate
    implementation and is not affected (it strips the v before re-adding one).
  • The same logic exists on main at scripts/releaser/v1/docs.go; this PR
    targets release/2.35.

This PR was generated by Coder Agents.

@mtojek
mtojek merged commit f2653d4 into release/2.35 Jul 15, 2026
33 of 34 checks passed
@mtojek
mtojek deleted the fix/release-calendar-doubled-version-prefix branch July 15, 2026 10:51
mtojek added a commit that referenced this pull request Jul 15, 2026
…st release link (#27260)

## Problem

The interactive releaser (`scripts/releaser`) renders the "Latest
Release"
cell of the release calendar with a doubled version prefix, e.g.
`[vv2.35.0](.../tag/v2.35.0)`.

`version.String()` already returns a `v`-prefixed string (e.g.
`v2.35.0`),
but `updateCalendar` wrapped it in a `"[v%s]"` template, so the link
label
gained a second `v`. The tag URL was already correct because release
tags
carry the `v` prefix.

## Fix

Drop the extra `v` from the label template (`"[v%s]"` → `"[%s]"`). The
URL is
unchanged.

- Label before: `[vv2.35.0]`
- Label after: `[v2.35.0]`

## Test

Added `scripts/releaser/v1/docs_test.go`:

- `TestUpdateCalendarLatestReleaseVersionPrefix` asserts the
`LatestRelease`
cell for a matching row on both a patch and a minor release. It fails on
the
  old code (`[vv2.35.x]`) and passes with the fix.
- `TestUpdateCalendarNotReleasedRowName` covers the `Not Released` →
`Mainline`
  promotion and the major.minor "Release name" link (patch omitted).

<details>
<summary>Investigation notes</summary>

- Entry path: `scripts/release.sh` → `go run ./scripts/releaser
--legacy` →
  `runRelease` → `promptAndUpdateDocs` → `updateReleaseDocs` →
`updateCalendarFile` → `updateCalendar` (`scripts/releaser/v1/docs.go`).
- Root cause in `updateCalendar`: `fmt.Sprintf("[v%s](%s)",
newVer.String(), ...)`
  combined with `version.String()` returning `v%d.%d.%d`.
- Only the link label was affected; the `releaseTagURLFmt` URL was
correct
  because tags are `v`-prefixed.
- The standalone `scripts/update-release-calendar.sh` is a separate
implementation and is not affected (it strips the `v` before re-adding
one).
- Companion PR for `release/2.35` (file `scripts/releaser/docs.go`):
#27259.

</details>

---
This PR was generated by Coder Agents.
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.