fix(scripts/releaser): remove doubled "v" in release calendar latest release link - #27259
#27259Merged
mtojek merged 2 commits intoJul 15, 2026
release/2.35coder/coder:release/2.35from
fix/release-calendar-doubled-version-prefixcoder/coder:fix/release-calendar-doubled-version-prefixCopy head branch name to clipboard
Merged
fix(scripts/releaser): remove doubled "v" in release calendar latest release link#27259mtojek merged 2 commits intorelease/2.35coder/coder:release/2.35from fix/release-calendar-doubled-version-prefixcoder/coder:fix/release-calendar-doubled-version-prefixCopy head branch name to clipboard
mtojek merged 2 commits into
release/2.35coder/coder:release/2.35from
fix/release-calendar-doubled-version-prefixcoder/coder:fix/release-calendar-doubled-version-prefixCopy head branch name to clipboard
Conversation
johnstcn
approved these changes
Jul 15, 2026
mtojek
added a commit
that referenced
this pull request
Jul 15, 2026
…st release link (#27260) ## Problem The interactive releaser (`scripts/releaser`) renders the "Latest Release" cell of the release calendar with a doubled version prefix, e.g. `[vv2.35.0](.../tag/v2.35.0)`. `version.String()` already returns a `v`-prefixed string (e.g. `v2.35.0`), but `updateCalendar` wrapped it in a `"[v%s]"` template, so the link label gained a second `v`. The tag URL was already correct because release tags carry the `v` prefix. ## Fix Drop the extra `v` from the label template (`"[v%s]"` → `"[%s]"`). The URL is unchanged. - Label before: `[vv2.35.0]` - Label after: `[v2.35.0]` ## Test Added `scripts/releaser/v1/docs_test.go`: - `TestUpdateCalendarLatestReleaseVersionPrefix` asserts the `LatestRelease` cell for a matching row on both a patch and a minor release. It fails on the old code (`[vv2.35.x]`) and passes with the fix. - `TestUpdateCalendarNotReleasedRowName` covers the `Not Released` → `Mainline` promotion and the major.minor "Release name" link (patch omitted). <details> <summary>Investigation notes</summary> - Entry path: `scripts/release.sh` → `go run ./scripts/releaser --legacy` → `runRelease` → `promptAndUpdateDocs` → `updateReleaseDocs` → `updateCalendarFile` → `updateCalendar` (`scripts/releaser/v1/docs.go`). - Root cause in `updateCalendar`: `fmt.Sprintf("[v%s](%s)", newVer.String(), ...)` combined with `version.String()` returning `v%d.%d.%d`. - Only the link label was affected; the `releaseTagURLFmt` URL was correct because tags are `v`-prefixed. - The standalone `scripts/update-release-calendar.sh` is a separate implementation and is not affected (it strips the `v` before re-adding one). - Companion PR for `release/2.35` (file `scripts/releaser/docs.go`): #27259. </details> --- This PR was generated by Coder Agents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The interactive releaser (
scripts/releaser) renders the "Latest Release"cell of the release calendar with a doubled version prefix, e.g.
[vv2.35.0](.../tag/v2.35.0).version.String()already returns av-prefixed string (e.g.v2.35.0),but
updateCalendarwrapped it in a"[v%s]"template, so the link labelgained a second
v. The tag URL was already correct because release tagscarry the
vprefix.Fix
Drop the extra
vfrom the label template ("[v%s]"→"[%s]"). The URL isunchanged.
[vv2.35.0][v2.35.0]Test
Added
TestUpdateCalendarLatestReleaseVersionPrefix, which asserts theLatestReleasecell for a matching row on both a patch and a minor release.It fails on the old code (
[vv2.35.x]) and passes with the fix.Investigation notes
scripts/release.sh→go run ./scripts/releaser→runRelease→promptAndUpdateDocs→updateReleaseDocs→updateCalendarFile→updateCalendar(scripts/releaser/docs.go).updateCalendar:fmt.Sprintf("[v%s](%s)", newVer.String(), ...)combined with
version.String()returningv%d.%d.%d.releaseTagURLFmtURL was correctbecause tags are
v-prefixed.scripts/update-release-calendar.shis a separateimplementation and is not affected (it strips the
vbefore re-adding one).mainatscripts/releaser/v1/docs.go; this PRtargets
release/2.35.This PR was generated by Coder Agents.