Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Health: "Mute warnings" silently suppresses top-nav banner for error-severity sections #27557

Copy link
Copy link

Description

@tracyjohnsonux
Issue body actions

Summary

The Mute warnings button on the Health pages toggles a section's entry in dismissed_healthchecks, which drives two different consumers with different scopes. As a result, muting a warning-severity section has a visible effect (a bell-off icon in the sidebar via HealthLayout.tsx:164), but muting an error-severity section additionally drops it from the top-nav error banner (via getHealthErrors in DeploymentBannerView.tsx:424, which gates on severity === "error" && !dismissed).

The label "Mute warnings" describes the sidebar behavior well, but users muting a section while it is at error severity are silently dropping an outage indicator from the top-nav. This is pre-existing behavior (not introduced by #27554), and #27554 explicitly kept the "Mute warnings" wording per the requester.

Options

  1. Rename or re-scope the mute so it only affects warning-severity sections, and give error-severity sections a separate, deliberately loud path.
  2. Restrict getHealthErrors so muting no longer suppresses error-severity sections in the top-nav; keep muting purely a sidebar/UI-noise concern.
  3. Change the label to something like "Mute this section" plus a tooltip that discloses both effects.
  4. Accept as-is and document the behavior.

Context


Filed by Coder Agents on behalf of @tracyjohnsonux.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    siteArea: frontend dashboardArea: frontend dashboard

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.