Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feature: support OAuth token revocation #15575

Copy link
Copy link

Description

@johnstcn
Issue body actions

Problem

Coder currently does not revoke users' oauth tokens when they unlink an account.
This is explicitly called out here:

info="This does not revoke the access token from the oauth2 provider.

RFC 7009 specifies a mechanism whereby OAuth authorization servers may expose an endpoint allowing immediate revocation of an access token or refresh token.

This is supported by the following external authentication providers:

Unfortunately, this does not appear to be uniformly supported across providers.
It is currently not supported / unknown on these providers:

Some providers provide custom implementations not in line with the spec:

Proposed Solution

When a user unlinks their account, coderd should attempt to revoke the token via the /revoke endpoint if configured.
The token revocation endpoint should be specified by CODER_EXTERNAL_AUTH_#_REVOKE_URL.
This will be done on a 'best effort' basis. If the authorization server returns any response other than 200, we should assume that the token revocation failed and advise the user to delete the token manually.

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

Morty Proxy This is a proxified and sanitized view of the page, visit original site.