Feature/second activity#10
Merged
Ilianabeziani merged 6 commits intoFeb 22, 2019
developcodeAndRain/SimpleLoginForm:developfrom
feature/second-activitycodeAndRain/SimpleLoginForm:feature/second-activityCopy head branch name to clipboard
Merged
Feature/second activity#10Ilianabeziani merged 6 commits intodevelopcodeAndRain/SimpleLoginForm:developfrom feature/second-activitycodeAndRain/SimpleLoginForm:feature/second-activityCopy head branch name to clipboard
Ilianabeziani merged 6 commits into
developcodeAndRain/SimpleLoginForm:developfrom
feature/second-activitycodeAndRain/SimpleLoginForm:feature/second-activityCopy head branch name to clipboard
Conversation
send user login details to second activity
Pass user login details to second activity
test - remove secondActivity
codeAndRain
reviewed
Feb 22, 2019
| case R.id.submit_button: | ||
| String username = usernameEditText.getText().toString(); | ||
| String password = passwordEditText.getText().toString(); | ||
| Intent i = new Intent(this, SecondActivity.class); |
Owner
There was a problem hiding this comment.
Let us have meaningful names for variables. Can we change 'i' to something meaningful like 'intent' ?
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:layout_margin="20dp" |
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_margin="20dp" | ||
| android:hint="Username : " |
| android:id="@+id/username_label_textview" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_margin="20dp" |
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_margin="20dp" | ||
| android:textSize="20dp" |
changes have been implemented
codeAndRain
approved these changes
Feb 22, 2019
Owner
|
Do not merge yet. There are some conflicts in the MainActivity.java class |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.