Remove aichat-polling experiment - #60703
#60703Merged
fisher-alice merged 3 commits intoAug 29, 2024
stagingcode-dot-org/code-dot-org:stagingfrom
alice/test-active-jobscode-dot-org/code-dot-org:alice/test-active-jobsCopy head branch name to clipboard
Merged
Remove aichat-polling experiment#60703fisher-alice merged 3 commits intostagingcode-dot-org/code-dot-org:stagingfrom alice/test-active-jobscode-dot-org/code-dot-org:alice/test-active-jobsCopy head branch name to clipboard
fisher-alice merged 3 commits into
stagingcode-dot-org/code-dot-org:stagingfrom
alice/test-active-jobscode-dot-org/code-dot-org:alice/test-active-jobsCopy head branch name to clipboard
Conversation
fisher-alice
marked this pull request as ready for review
August 28, 2024 18:35
fisher-alice
marked this pull request as draft
August 28, 2024 19:30
bencodeorg
approved these changes
Aug 28, 2024
| chatEventsCurrent.filter(isChatMessage) as ChatMessage[], | ||
| aiCustomizations, | ||
| aichatContext, | ||
| experiments.isEnabled(experiments.AICHAT_POLLING) |
Contributor
There was a problem hiding this comment.
Remove this experiment?
fisher-alice
marked this pull request as ready for review
August 28, 2024 20:19
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents the testing of the ActiveJob API for aichat completion (currently hidden behind experiment 'aichat-polling') on production and removes the experiment flag.
This is the final step to a multi-PR process implemented by @sanchitmalhotra126 .
Screencast video of dev network tab with experiment when sending a chat request on an aichat level on production:
Screen.Recording.2024-08-28.at.9.41.19.AM.mov
This is a screenshot of the dev network tab with the experiment disabled. Note that the api endpoint called is
chat_completioninstead ofstart_chat_completion/chat_request.After submitting multiple aichat requests, I checked the
AichatRequeststable to confirm that the requests were logged as expected.Here's a screenshot of the
AichatRequeststable while polling is taking place and then when the request was resolved (see row 12):As requested by @sanchitmalhotra126 , I let infra team know about this update - Slack thread.
Links
jira
Testing story
After removing the experiment, I disabled the experiment locally and then confirmed that the Active Job API was now being called successfully.
Deployment strategy
Follow-up work
Remove
chat_completionaction and associated code. Update tests!Privacy
Security
Caching
PR Checklist: