NAV - Add settings page (and remove body styles) - #60702
#60702NAV - Add settings page (and remove body styles)#60702kobryan0619 merged 6 commits intostagingcode-dot-org/code-dot-org:stagingfrom kaitie/NAV-add-settings-pagecode-dot-org/code-dot-org:kaitie/NAV-add-settings-pageCopy head branch name to clipboard
Conversation
| @import '@cdo/apps/componentLibrary/common/styles/mixins'; | ||
|
|
||
| // In order to make typography work correctly with em units. (Design system is build for 16px default font size) | ||
| body { |
There was a problem hiding this comment.
This was the line causing issues in the other components in the TeacherNavigationRouter file. I also don't think setting the body here is best practice. I removed it and then adjusted other CSS files to ensure the section-setup page was accurate.
There was a problem hiding this comment.
I also looked for anywhere else where we used sections-refresh.module.scss OR anywhere where we were pulling in a component that was using this module, and double checked that all the text was right. The good news is that this file is only connected this SectionSetup page AND a pop-up dialog for first time section creators. I verified both of these.
lfryemason
left a comment
There was a problem hiding this comment.
Thanks for spending time looking for the cause, reverting and remaking the PR! I'm hoping that we don't run in to this issue again now that we've removed the body { css.
Modifies prior PR and revert to avoid styles changes on separate pages.