Use Input/Label combos for new sign-up teacher view and school association - #60532
#60532Merged
TurnerRiley merged 74 commits intoAug 21, 2024
stagingcode-dot-org/code-dot-org:stagingfrom
use-input-label-combos-for-teacher-viewcode-dot-org/code-dot-org:use-input-label-combos-for-teacher-viewCopy head branch name to clipboard
Merged
Use Input/Label combos for new sign-up teacher view and school association#60532TurnerRiley merged 74 commits intostagingcode-dot-org/code-dot-org:stagingfrom use-input-label-combos-for-teacher-viewcode-dot-org/code-dot-org:use-input-label-combos-for-teacher-viewCopy head branch name to clipboard
TurnerRiley merged 74 commits into
stagingcode-dot-org/code-dot-org:stagingfrom
use-input-label-combos-for-teacher-viewcode-dot-org/code-dot-org:use-input-label-combos-for-teacher-viewCopy head branch name to clipboard
Conversation
kelbyhawn
approved these changes
Aug 21, 2024
kelbyhawn
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating this too! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates school association and the teacher view for the new sign-up flow to make them more accessible by using the input + label combo (rather than an input with a separate text element above it). This allows the user to click the text of the field to interact with the element as well!
Previous School Association view
New School Association view (essentially identical)
Previous view for finishing teacher sign-up flow
New view for finishing teacher sign-up flow
Links
Follows this comment in the student sign-up flow PR: here
Testing story
Local testing.