Purging user deletes the associated Census Inaccuracy Investigations - #36657
#36657Merged
daynew merged 1 commit intoSep 10, 2020
stagingcode-dot-org/code-dot-org:stagingfrom
fnd-1269-delete-census-inaccuracycode-dot-org/code-dot-org:fnd-1269-delete-census-inaccuracyCopy head branch name to clipboard
Merged
Purging user deletes the associated Census Inaccuracy Investigations#36657daynew merged 1 commit intostagingcode-dot-org/code-dot-org:stagingfrom fnd-1269-delete-census-inaccuracycode-dot-org/code-dot-org:fnd-1269-delete-census-inaccuracyCopy head branch name to clipboard
daynew merged 1 commit into
stagingcode-dot-org/code-dot-org:stagingfrom
fnd-1269-delete-census-inaccuracycode-dot-org/code-dot-org:fnd-1269-delete-census-inaccuracyCopy head branch name to clipboard
Conversation
daynew
force-pushed
the
fnd-1269-delete-census-inaccuracy
branch
from
September 9, 2020 00:56
cb6366a to
254ff07
Compare
Hamms
approved these changes
Sep 9, 2020
Hamms
left a comment
Contributor
There was a problem hiding this comment.
I don't have a ton of context in this area, but this all makes sense to me and the test is super clear!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug - Some soft-deleted teacher accounts failed to be purged.
Cause - Deleting the CensusSubmissions associated with the teach account failed because there was still a CensusInaccuracyInvestigation associated with the teacher's CensusSubmission.
Fix - Delete associated CensusInaccuracyInvestigations before deleting the CensusSubmissions.
Links
Testing story
Reviewer Checklist: