Merged
Create MarkdownPreview component for edit pages#36367
Conversation
7 tasks
davidsbailey
approved these changes
Aug 20, 2020
uponthesun
reviewed
Aug 20, 2020
uponthesun
left a comment
There was a problem hiding this comment.
Would it make more sense to include the textarea and event handler in this preview component, since that's also needed in each place? Or do we need the flexibility of configuring that separately?
| dropdown: { | ||
| margin: '0 6px' | ||
| }, | ||
| box: { |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #36363 and #36346. Creates a simple component for the markdown preview that can be used on editing pages. Looks the same as what is in those PRs just extracts out the logic into one place.
Testing story
-Updated ScriptEditorTest and CourseEditorTest
-Created test for MarkdownPreview
Reviewer Checklist: