Style changes for non-English /courses page. - #35731
#35731Merged
daynew merged 1 commit intoJul 10, 2020
stagingcode-dot-org/code-dot-org:stagingfrom
fnd-1214-layout-improvements-for-course-wide-blockscode-dot-org/code-dot-org:fnd-1214-layout-improvements-for-course-wide-blocksCopy head branch name to clipboard
Merged
Style changes for non-English /courses page.#35731daynew merged 1 commit intostagingcode-dot-org/code-dot-org:stagingfrom fnd-1214-layout-improvements-for-course-wide-blockscode-dot-org/code-dot-org:fnd-1214-layout-improvements-for-course-wide-blocksCopy head branch name to clipboard
daynew merged 1 commit into
stagingcode-dot-org/code-dot-org:stagingfrom
fnd-1214-layout-improvements-for-course-wide-blockscode-dot-org/code-dot-org:fnd-1214-layout-improvements-for-course-wide-blocksCopy head branch name to clipboard
Conversation
Contributor
|
Nit: can we make the Age range just slightly larger than the description text? For an example, see https://code.org/student/elementary (in English) |
daynew
force-pushed
the
fnd-1214-layout-improvements-for-course-wide-blocks
branch
2 times, most recently
from
July 9, 2020 23:01
1ac7f61 to
3cdf16d
Compare
* Prevent title cutoff for the course * Add the recommended age ranges for the cours * Make neighbor course blocks the same size.
daynew
force-pushed
the
fnd-1214-layout-improvements-for-course-wide-blocks
branch
from
July 10, 2020 00:31
3cdf16d to
cbd65b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some UI improvements for the i18n experience on https://studio.code.org/courses/lang/es-mx . See the design doc in the links section for the mocks.
Links
Screenshots
Before
After
After + RTL
Testing story
Reviewer Checklist: