Fix the scoring for principal implementation - should be YES/NO for m… - #26412
#26412Merged
mehalshah merged 2 commits intoDec 19, 2018
stagingcode-dot-org/code-dot-org:stagingfrom
fix_principal_implementation_scoringcode-dot-org/code-dot-org:fix_principal_implementation_scoringCopy head branch name to clipboard
Merged
Fix the scoring for principal implementation - should be YES/NO for m…#26412mehalshah merged 2 commits intostagingcode-dot-org/code-dot-org:stagingfrom fix_principal_implementation_scoringcode-dot-org/code-dot-org:fix_principal_implementation_scoringCopy head branch name to clipboard
mehalshah merged 2 commits into
stagingcode-dot-org/code-dot-org:stagingfrom
fix_principal_implementation_scoringcode-dot-org/code-dot-org:fix_principal_implementation_scoringCopy head branch name to clipboard
Conversation
…inimum criteria.
After this is done, a migration is needed roughly like
Pd::Application::Teacher1920Application.select {|a| a.response_scores_hash[:meets_minimum_criteria_scores][:principal_implementation].in?(['0', '2'])}.each |x|
score = x.response_scores_hash[:meets_minimum_criteria_scores]
x.update(response_scores: response_scores_hash.deep_merge({meets_minimum_criteria_scores: {prinipcal_implementation: score == '2' ? 'Yes' : 'No'}}))
end
clareconstantine
approved these changes
Dec 18, 2018
| renderScoringDropdown(key, category) { | ||
| const scores = TeacherValidScores[_.camelCase(key)][_.camelCase(category)] || TeacherValidScores[_.camelCase(key)]; | ||
|
|
||
| console.log(category); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…inimum criteria.
After this is done, a migration is needed roughly like