Remove the option to hide_custom_blocks, make it the default - #26392
#26392Merged
joshlory merged 2 commits intoDec 19, 2018
stagingcode-dot-org/code-dot-org:stagingfrom
hide-custom-blocks-optioncode-dot-org/code-dot-org:hide-custom-blocks-optionCopy head branch name to clipboard
Merged
Remove the option to hide_custom_blocks, make it the default#26392joshlory merged 2 commits intostagingcode-dot-org/code-dot-org:stagingfrom hide-custom-blocks-optioncode-dot-org/code-dot-org:hide-custom-blocks-optionCopy head branch name to clipboard
hide_custom_blocks, make it the default#26392joshlory merged 2 commits into
stagingcode-dot-org/code-dot-org:stagingfrom
hide-custom-blocks-optioncode-dot-org/code-dot-org:hide-custom-blocks-optionCopy head branch name to clipboard
Conversation
Hamms
approved these changes
Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only hiding the option for now (leaving the current settings on existing levels). A more drastic step would be to nuke the option entirely:
code-dot-org/apps/src/appMain.js
Lines 101 to 103 in 8990f16
Request from @mikeharv.