Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Optionally authenticate some GitHub API Requests - #26379

#26379
Merged
sureshc merged 2 commits into
stagingcode-dot-org/code-dot-org:stagingfrom
authenticate-additional-github-requestscode-dot-org/code-dot-org:authenticate-additional-github-requestsCopy head branch name to clipboard
Dec 18, 2018
Merged

Optionally authenticate some GitHub API Requests#26379
sureshc merged 2 commits into
stagingcode-dot-org/code-dot-org:stagingfrom
authenticate-additional-github-requestscode-dot-org/code-dot-org:authenticate-additional-github-requestsCopy head branch name to clipboard

Conversation

@sureshc

@sureshc sureshc commented Dec 14, 2018

Copy link
Copy Markdown
Contributor

I was unable to use several important commands (like Mark Test Build Green and Deploy To Production) in the Developer of the Day script because some of the API calls it issues to GitHub are not-authenticated and the Seattle office IP address had exceeded their rate limit:

GET https://api.github.com/repos/code-dot-org/code-dot-org/branches/test: 403 - API rate limit exceeded for 74.85.93.166. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) // See: https://developer.github.com/v3/#rate-limiting (Octokit::TooManyRequests)

@nkiruka helped me add an optional argument to GitHub.sha to control whether to authenticate the API call.

@sureshc
sureshc requested review from Hamms and nkiruka December 14, 2018 23:04

@nkiruka nkiruka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sureshc
sureshc merged commit b81d212 into staging Dec 18, 2018
@sureshc
sureshc deleted the authenticate-additional-github-requests branch December 18, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.