Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DTP (Test > Production: f7c4ffe2) - #26348

#26348
Merged
islemaster merged 4 commits into
productioncode-dot-org/code-dot-org:productionfrom
dtp_candidate_f7c4ffe2code-dot-org/code-dot-org:dtp_candidate_f7c4ffe2Copy head branch name to clipboard
Dec 13, 2018
Merged

DTP (Test > Production: f7c4ffe2)#26348
islemaster merged 4 commits into
productioncode-dot-org/code-dot-org:productionfrom
dtp_candidate_f7c4ffe2code-dot-org/code-dot-org:dtp_candidate_f7c4ffe2Copy head branch name to clipboard

Conversation

@islemaster

Copy link
Copy Markdown
Contributor

No description provided.

islemaster and others added 4 commits December 12, 2018 14:49
Not entirely sure of the root cause here - it seems like we tripped on a change in Chrome 71 (and maybe earlier in Firefox based on @Hamms' reports).  But we consistently saw this problem with extreme page width/height when these tooltips are rendered inside an element with a `transform: rotate(xdeg)` style.

To solve, I've added an extra wrapper div around progress bubbles and placed the tooltip outside of the rotated content.  Verified within storybook where we had a really easy min-repro.  This may have subtly changed the tooltip height, checking that out now.
Fix oversize page by pulling tooltip out of rotated div
DTT (Staging > Test) [robo-dtt]
@islemaster
islemaster merged commit e361240 into production Dec 13, 2018
@deploy-code-org
deploy-code-org deleted the dtp_candidate_f7c4ffe2 branch December 13, 2018 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.