DTP (Test > Production: f7c4ffe2) - #26348
#26348Merged
islemaster merged 4 commits intoDec 13, 2018
productioncode-dot-org/code-dot-org:productionfrom
dtp_candidate_f7c4ffe2code-dot-org/code-dot-org:dtp_candidate_f7c4ffe2Copy head branch name to clipboard
Merged
DTP (Test > Production: f7c4ffe2)#26348islemaster merged 4 commits intoproductioncode-dot-org/code-dot-org:productionfrom dtp_candidate_f7c4ffe2code-dot-org/code-dot-org:dtp_candidate_f7c4ffe2Copy head branch name to clipboard
islemaster merged 4 commits into
productioncode-dot-org/code-dot-org:productionfrom
dtp_candidate_f7c4ffe2code-dot-org/code-dot-org:dtp_candidate_f7c4ffe2Copy head branch name to clipboard
Conversation
Not entirely sure of the root cause here - it seems like we tripped on a change in Chrome 71 (and maybe earlier in Firefox based on @Hamms' reports). But we consistently saw this problem with extreme page width/height when these tooltips are rendered inside an element with a `transform: rotate(xdeg)` style. To solve, I've added an extra wrapper div around progress bubbles and placed the tooltip outside of the rotated content. Verified within storybook where we had a really easy min-repro. This may have subtly changed the tooltip height, checking that out now.
Fix oversize page by pulling tooltip out of rotated div
DTT (Staging > Test) [robo-dtt]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.