show video download error in finish dialog - #26270
#26270Merged
davidsbailey merged 2 commits intoNov 29, 2018
stagingcode-dot-org/code-dot-org:stagingfrom
finish-download-animation-failcode-dot-org/code-dot-org:finish-download-animation-failCopy head branch name to clipboard
Merged
show video download error in finish dialog#26270davidsbailey merged 2 commits intostagingcode-dot-org/code-dot-org:stagingfrom finish-download-animation-failcode-dot-org/code-dot-org:finish-download-animation-failCopy head branch name to clipboard
davidsbailey merged 2 commits into
stagingcode-dot-org/code-dot-org:stagingfrom
finish-download-animation-failcode-dot-org/code-dot-org:finish-download-animation-failCopy head branch name to clipboard
Conversation
Member
Author
|
I also manually verified that after failing to download and then closing and reopening the finish dialog, the warning disappears. |
Hamms
approved these changes
Nov 29, 2018
| font-size: large; | ||
| } | ||
|
|
||
| #download-replay-video-error { |
Contributor
There was a problem hiding this comment.
I don't love adding a definition to our global scss just for this one div
Member
Author
There was a problem hiding this comment.
moved to inline. haha, yes, see "split up 2MB of common js/css files" in my eng swarm sprint wish list 😛 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes code-dot-org/dance-party#519
this solution provides parity in the Finish with what we show in the Share dialog -- if the animation video download fails, we let the Animation button keep spinning, and show a warning message asking them to try again:
