Project Gallery: only restrict advanced project types if sharing is disabled - #26173
#26173Project Gallery: only restrict advanced project types if sharing is disabled #26173Erin007 merged 4 commits intostagingcode-dot-org/code-dot-org:stagingfrom sharing-restrictions-only-app-and-gamecode-dot-org/code-dot-org:sharing-restrictions-only-app-and-gameCopy head branch name to clipboard
Conversation
davidsbailey
left a comment
There was a problem hiding this comment.
Code change looks good! Please add a simple test. See sharing_disabled in projects_list_test.rb for some existing examples which test this part of the code. OK to do it in a later PR if you need.
| # Sharing of advanced project types to the public gallery is restricted for | ||
| # young students unless sharing is explciitly enabled by the student's | ||
| # teacher for privacy reasons. | ||
| ADVANCED_PROJECT_TYPES = ['applab', 'gamelab'] |
There was a problem hiding this comment.
What about Sprite Lab? I don't think it lets you upload/create any images, but it allows arbitrary text and we don't have any PII filtering in place yet. Maybe we should keep it locked down for now.
There was a problem hiding this comment.
Good idea. I didn't think about Sprite Lab. I'll add and we can revisit later if needed.
97b8d05 to
9c1ad52
Compare
|
@uponthesun if you're still curious, this ended up being the fix for only a limited number of Dance Party projects showing in the gallery. Thanks for taking a look at my notes, and feel free to reach out with any follow-up questions. |
Dance Party Issue 402
When fetching project information for the public project gallery, there is currently a check that says if the owner of the project has sharing disabled, don't include that project in the list to show in the gallery. Right now the project is not included in the list of projects to show in the project gallery if the owner has sharing disabled regardless of project type. Sharing restrictions should only apply to advanced project types. This bug fix excludes only App Lab, Game Lab and Sprite Lab projects from being shown in the public gallery if sharing is disabled; even if sharing is disabled all other project types, including dance, will show in the gallery. This change will fix the issue reported that not all published Dance Party projects show in the gallery (a symptom of the broader problem described).