Projects: add a default Dance Party image if a thumbnail isn't generated - #26168
#26168Merged
Erin007 merged 1 commit intoNov 20, 2018
stagingcode-dot-org/code-dot-org:stagingfrom
dance-default-thumbnailcode-dot-org/code-dot-org:dance-default-thumbnailCopy head branch name to clipboard
Merged
Projects: add a default Dance Party image if a thumbnail isn't generated#26168Erin007 merged 1 commit intostagingcode-dot-org/code-dot-org:stagingfrom dance-default-thumbnailcode-dot-org/code-dot-org:dance-default-thumbnailCopy head branch name to clipboard
Erin007 merged 1 commit into
stagingcode-dot-org/code-dot-org:stagingfrom
dance-default-thumbnailcode-dot-org/code-dot-org:dance-default-thumbnailCopy head branch name to clipboard
Conversation
maddiedierker
approved these changes
Nov 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a thumbnail isn't generated for a Dance Party project (either because the project hasn't been run yet or the thumbnail generation was flaky), we will now default to cool cat and shark image rather than the teal arrow default we use on other project types. This new Dance Party default will show up in the share dialog and the project gallery.
Before:
After:
Partially addresses issue #261