Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DTP (Test > Production: f8d3e5b7) - #26165

#26165
Merged
islemaster merged 54 commits into
productioncode-dot-org/code-dot-org:productionfrom
dtp_candidate_f8d3e5b7code-dot-org/code-dot-org:dtp_candidate_f8d3e5b7Copy head branch name to clipboard
Nov 19, 2018
Merged

DTP (Test > Production: f8d3e5b7)#26165
islemaster merged 54 commits into
productioncode-dot-org/code-dot-org:productionfrom
dtp_candidate_f8d3e5b7code-dot-org/code-dot-org:dtp_candidate_f8d3e5b7Copy head branch name to clipboard

Conversation

@islemaster

Copy link
Copy Markdown
Contributor

No description provided.

davidsbailey and others added 30 commits November 14, 2018 15:11
Users who had volunteered before we added the email preference weren't able to modify subscription preferences because the server was enforcing a requirement that there be an emai preference.

This adds the email preference dropdown to the "Update email preferences" UI.  It's not mandatory if the user already has an email preference, but if they don't, submitting the form will give an error that a value needs to be provided.
use animated gif for dance party tile on course catalog and sign in page
…st.rb so aquatic projects show in the public gallery
It turns out that enabling a language here will redirect _all_ links to
CB for that language to the language-specific version of that content,
even though we only generate language-specific versions of CB content
for the subset of content we are actively translating.

This results in all CB links except for that subset being broken. We are
disabling languages for now until we can figure out a more precise way
to link to CB content.
Every key press in the parameter name text field causes a new block to be created. Now that "delete" doesn't modify the block, one less block is created.
Backport fix from test -> staging
Looks like IE11 isn't waiting properly for the page to fully load, so we explicitly wait for .blocklySvg to exist before dragging blocks.

BONUS BONUS BONUS did you know we had tests checking block dragging in portrait mode? That are identical to the tests for block dragging in landscape mode?  And that they actually _run_ in landscape mode despite saying they'll run in portrait mode?

Deleted them.
Stabilize flappydrag.feature and simpledrag.feature
DTT (Brad on weekend working on test stability)
When adjusting volunteer subscription preference, a red asterisk is now always shown by the 18+ option.  Also, if there isn't already an email preference, a red asterisk is shown by that choice too.
Projects: string to symbol for fetching published projects
Erin007 and others added 24 commits November 19, 2018 11:47
…able

Project Gallery: publishable Minecraft Aquatic
Disable locale-specific links to CurriculumBuilder
Volunteer: fix unsubscribe for users without email preference
…orks

Dance: show "How It Works" button on shared level
Add info about new Amazon store and posters to HOC event confirmation email
move Dance scripts to beginning of HoC section
Depends on code-dot-org/blockly#157

A custom block can give any field input a type of `"ClampedNumber(min,max)"` where `min` and `max` are optional and define bounds for acceptable number input to the field.
Sets a minimum interval value on the input validation for the everySeconds and everySecondsRange custom blocks using the new ClampedNumber field type.
Every key press in the parameter name text field causes a new block to be created. Now that "delete" doesn't modify the block, one less block is created.
Validate minimum input values for `everySeconds` block
Rename Dance_Party_11.5 to Dance_Party_11_5
DTT (Staging > Test) [robo-dtt]
@islemaster
islemaster merged commit 5ae05d8 into production Nov 19, 2018
@deploy-code-org
deploy-code-org deleted the dtp_candidate_f8d3e5b7 branch November 19, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.