Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Dance landing page - Change main tutorial hero background and adjust line height - #26075

#26075
Merged
nkiruka merged 1 commit into
stagingcode-dot-org/code-dot-org:stagingfrom
fix-top-herocode-dot-org/code-dot-org:fix-top-heroCopy head branch name to clipboard
Nov 14, 2018
Merged

Dance landing page - Change main tutorial hero background and adjust line height#26075
nkiruka merged 1 commit into
stagingcode-dot-org/code-dot-org:stagingfrom
fix-top-herocode-dot-org/code-dot-org:fix-top-heroCopy head branch name to clipboard

Conversation

@nkiruka

@nkiruka nkiruka commented Nov 14, 2018

Copy link
Copy Markdown
Contributor

The PR is to fix the main tutorial box regression. The main tutorial image was not large enough to adjust for additional names of artists.

  • Other changes

  • Increased line height to 19px for legibility

  • Added padding to the text

  • Before: background img height 334

screen shot 2018-11-13 at 10 17 24 pm

  • After: background img height 400 px. At this height, "featuring" should not overlap with the dance party tile if more names are added to the list.

screen shot 2018-11-13 at 9 52 43 pm

@nkiruka
nkiruka merged commit 1db46ea into staging Nov 14, 2018
@nkiruka
nkiruka deleted the fix-top-hero branch December 20, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.