Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

use selenium to click during shared sign-in steps - #26074

#26074
Merged
davidsbailey merged 1 commit into
stagingcode-dot-org/code-dot-org:stagingfrom
always-selenium-signincode-dot-org/code-dot-org:always-selenium-signinCopy head branch name to clipboard
Nov 14, 2018
Merged

use selenium to click during shared sign-in steps#26074
davidsbailey merged 1 commit into
stagingcode-dot-org/code-dot-org:stagingfrom
always-selenium-signincode-dot-org/code-dot-org:always-selenium-signinCopy head branch name to clipboard

Conversation

@davidsbailey

@davidsbailey davidsbailey commented Nov 14, 2018

Copy link
Copy Markdown
Member

#26064 made signing_in.feature use selenium rather than jquery to click the "sign in" buttons. This PR makes the I sign in as "..." step, which is used across many UI tests, use the same mechanism.

@islemaster islemaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@davidsbailey
davidsbailey changed the base branch from signin-with-selenium to staging November 14, 2018 19:52
@davidsbailey
davidsbailey merged commit f352585 into staging Nov 14, 2018
@davidsbailey
davidsbailey deleted the always-selenium-signin branch November 14, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.