use selenium to click elements by id when possible - #26043
#26043use selenium to click elements by id when possible#26043
Conversation
islemaster
left a comment
There was a problem hiding this comment.
👍 If it passes tests. It may be worth using commit tags to check other browsers against this change on Circle (e.g. [test firefox] [test safari] [test ie])
|
Looks like a slew of related test failures. Do elements need to be scrolled into view? |
|
unlikely, because the error shown after clicking the "more" link in circle is: |
|
new plan: this PR is going to be the "shotgun approach" which targets only .feature files. any that fail, I'll just revert and submit what remains. I'll fire up a separate PR for the sign-in tests which takes a more careful approach. I'm hesitant to run firefox, safari, ie, etc because I know those don't always pass on circle even without any changes from staging. testing the extent of this here before subjecting my PR to it: https://circleci.com/gh/code-dot-org/code-dot-org/81417 |
|
@davidsbailey if you're going to break up the tests anyway and the sign-in tests need extra work, I'm happy to take them back on. Just let me know! |
|
Hi @Erin007 , don't worry about it, I think I know what to do for the sign in steps. I'll send something shortly. |
|
FWIW, the following 12 configurations failed after reruns on circle against staging: I'll run this PR against safari and firefox, skipping IE to keep the noise down: https://circleci.com/gh/code-dot-org/code-dot-org/81460 |
No description provided.