Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

use selenium to click elements by id when possible - #26043

#26043
Merged
davidsbailey merged 4 commits into
stagingcode-dot-org/code-dot-org:stagingfrom
click-with-seleniumcode-dot-org/code-dot-org:click-with-seleniumCopy head branch name to clipboard
Nov 14, 2018
Merged

use selenium to click elements by id when possible#26043
davidsbailey merged 4 commits into
stagingcode-dot-org/code-dot-org:stagingfrom
click-with-seleniumcode-dot-org/code-dot-org:click-with-seleniumCopy head branch name to clipboard

Conversation

@davidsbailey

Copy link
Copy Markdown
Member

No description provided.

@islemaster islemaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 If it passes tests. It may be worth using commit tags to check other browsers against this change on Circle (e.g. [test firefox] [test safari] [test ie])

@Erin007 Erin007 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dave!!

@Erin007

Erin007 commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

Looks like a slew of related test failures. Do elements need to be scrolled into view?

@davidsbailey

Copy link
Copy Markdown
Member Author

unlikely, because the error shown after clicking the "more" link in circle is: unknown error: Element <a class="button-signin linktag" href="//localhost-studio.code.org:3000/users/sign_in" id="signin_button">...</a> is not clickable at point (1063, 0). Other element would receive the click: <div class="header_right">...</div>. It looks like this is not the right element try to click with selenium. when I inspect in via chrome debugger, it is 0px and off the page. so a more fine-grained approach may be required here. recalculating...

@davidsbailey

Copy link
Copy Markdown
Member Author

new plan: this PR is going to be the "shotgun approach" which targets only .feature files. any that fail, I'll just revert and submit what remains. I'll fire up a separate PR for the sign-in tests which takes a more careful approach.

I'm hesitant to run firefox, safari, ie, etc because I know those don't always pass on circle even without any changes from staging. testing the extent of this here before subjecting my PR to it: https://circleci.com/gh/code-dot-org/code-dot-org/81417

@Erin007

Erin007 commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

@davidsbailey if you're going to break up the tests anyway and the sign-in tests need extra work, I'm happy to take them back on. Just let me know!

@davidsbailey

Copy link
Copy Markdown
Member Author

Hi @Erin007 , don't worry about it, I think I know what to do for the sign in steps. I'll send something shortly.

@davidsbailey

davidsbailey commented Nov 14, 2018

Copy link
Copy Markdown
Member Author

FWIW, the following 12 configurations failed after reruns on circle against staging:

Firefox45Win7_teacher_homepage
Firefox45Win7_yourschool
IE11Win10_applab_clipping
IE11Win10_applab_embed
IE11Win10_disallowedsharing
IE11Win10_gdpr_dialog
IE11Win10_manage_assets
IE11Win10_projects_applab_project
IE11Win10_sharepage
IE11Win10_sharepage_logo
IE11Win10_signing_in
SafariYosemite_spritelab_dancelab

I'll run this PR against safari and firefox, skipping IE to keep the noise down: https://circleci.com/gh/code-dot-org/code-dot-org/81460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.