Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Smaller image so it doesn't cover the sign-in button - #26036

#26036
Merged
islemaster merged 1 commit into
productioncode-dot-org/code-dot-org:productionfrom
hotfix-mc-imagecode-dot-org/code-dot-org:hotfix-mc-imageCopy head branch name to clipboard
Nov 13, 2018
Merged

Smaller image so it doesn't cover the sign-in button#26036
islemaster merged 1 commit into
productioncode-dot-org/code-dot-org:productionfrom
hotfix-mc-imagecode-dot-org/code-dot-org:hotfix-mc-imageCopy head branch name to clipboard

Conversation

@islemaster

@islemaster islemaster commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

Hotfix proposal

The problem:

image

Before:

before

After:

after

@islemaster

Copy link
Copy Markdown
Contributor Author

peek 2018-11-13 07-33

@Erin007 Erin007 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great solution to me. Thanks for the quick fix!

@islemaster
islemaster merged commit a54a8cd into production Nov 13, 2018
@islemaster
islemaster deleted the hotfix-mc-image branch November 13, 2018 15:38
@breville

Copy link
Copy Markdown
Member

fwiw, an interesting alternate would be pointer-events: none;

thanks for fixing!

@islemaster

Copy link
Copy Markdown
Contributor Author

Gah! That's totally the right fix, I was in such a rush this morning I didn't think it through and went with the first thing that worked. Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.