Merged
Conversation
0.3.21 -> 0.5.2
wjordan
force-pushed
the
mysql2_update
branch
from
December 12, 2018 20:44
4c69598 to
e240607
Compare
Contributor
Author
|
Reproduced the Pegasus test failures locally, it looks like the change triggering the failure was introduced in 0.4.3 or 0.4.4 (0.4.2 works fine, 0.4.3 is not supported in ActiveRecord, 0.4.4 generates test failures). |
Contributor
Author
|
Still tracking the failure down- it seems that setting |
Fixes failing Pegasus tests where FakeDashboard session gets closed and temporary tables are lost.
sureshc
approved these changes
Dec 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
mysql2client update from0.3.21to0.5.2should auto-close db connections properly, eliminating 'aborted client' errors on the MySQL server.