Merged
Import Level Concept Difficulties for new 2018 levels#25185
Conversation
Contributor
Author
|
@ryansloan can you spot-check the level changes to confirm that they match expectations? |
Contributor
|
I checked a handful and they LGTM |
joshlory
approved these changes
Oct 4, 2018
joshlory
left a comment
Contributor
There was a problem hiding this comment.
LGTM after resolving conflicts. Thank you for doing this import!
|
|
||
| lcd = LevelConceptDifficulty.find_or_create_by(level: level) | ||
| lcd.update!(concept_difficulties) | ||
| level.write_custom_level_file |
Contributor
There was a problem hiding this comment.
Only need to do this if we have a LCD for this level, right? Seeing a lot of edits on levels that don't actually change the LCD.
Contributor
Author
There was a problem hiding this comment.
Hmm, good catch. Lemme try and make this a bit smarter
Contributor
There was a problem hiding this comment.
Probably doesn't make a huge difference — the real (long-term) work item here is to not write values to the .level file unless they're different than the default value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the data contained in this spreadsheet