Set up auth for the pd application dashboard - #18893
#18893Merged
aoby merged 3 commits intoNov 3, 2017
stagingcode-dot-org/code-dot-org:stagingfrom
pd-application-dashboard-authcode-dot-org/code-dot-org:pd-application-dashboard-authCopy head branch name to clipboard
Merged
Set up auth for the pd application dashboard#18893aoby merged 3 commits intostagingcode-dot-org/code-dot-org:stagingfrom pd-application-dashboard-authcode-dot-org/code-dot-org:pd-application-dashboard-authCopy head branch name to clipboard
aoby merged 3 commits into
stagingcode-dot-org/code-dot-org:stagingfrom
pd-application-dashboard-authcode-dot-org/code-dot-org:pd-application-dashboard-authCopy head branch name to clipboard
Conversation
… teacher with an associated regional partner (meaning they are a program manager) can see it
mehalshah
approved these changes
Nov 3, 2017
added 2 commits
November 3, 2017 13:12
…regional partners to avoid adding a new DB query for all teachers. Fixed existing, and added some additional tests.
Contributor
Author
|
That approach was adding a DB query to every teacher for all auth requests. Luckily @wjordan 's recently added |
ewjordan
approved these changes
Nov 3, 2017
clareconstantine
approved these changes
Nov 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workshop admins and any teacher with an associated regional partner (meaning they are a program manager) can see it
CC @tanyaparker
FYI @ewjordan (as DotD - this needs to go out today)